Kohana Forums

Enyone know how to repear that??

Despite claims in other threads it appears to me that this issue is not fixed in the current version of ORM on github. Working with k3 and ORM updated on Jan 15th and A1 updated on Nov 25th I get this error when returning to a site with an existing cookie/session for a logged in user after closing the browser and opening it again. Happens in all browsers. [edit] after clearing browser cookies the error does not recur when the page is reloaded.

ErrorException [ Notice ]: Undefined index: id
MODPATH/orm/classes/kohana/orm.php [ 1308 ]
1303 *
1304 * @return bool
1305 */
1306 protected function empty_pk()
1307 {
1308 return (empty($this->_object[$this->_primary_key]) AND $this->_object[$this->_primary_key] !== '0');
1309 }
1310
1311 /**
1312 * Returns last executed query
1313 *
MODPATH/orm/classes/kohana/orm.php [ 1308 ] » Kohana_Core::error_handler()
MODPATH/orm/classes/kohana/orm.php [ 729 ] » Kohana_ORM->empty_pk()
MODPATH/orm/classes/kohana/orm.php [ 273 ] » Kohana_ORM->_load()
{PHP internal call} » Kohana_ORM->__call(arguments)
MODPATH/a1/classes/a1.php [ 118 ] » Model_User->loaded()
APPPATH/classes/controller/base.php [ 38 ] » A1->get_user()
APPPATH/classes/controller/website.php [ 27 ] » Controller_Base->before()
{PHP internal call} » Controller_Website->before()
SYSPATH/classes/kohana/request.php [ 857 ] » ReflectionMethod->invoke(arguments)
APPPATH/bootstrap.php [ 168 ] » Kohana_Request->execute()
DOCROOT/index.php [ 103 ] » require(arguments)


I've seen this happen a few times when the cookie (where I'm storing session data) gets corrupted, and the ORM isn't able to wakeup successfully. I'm not really sure if this is an ORM problem (A1 maybe)?, or what is causing it. I haven't been able to reproduce the problem, however if anyone is able to provide more information and how they can reproduce this issue it would be easier to figure out what we can do to fix it.

I have this problem after application crush (fatal error), and only cookie clearing helps.

It isn't (only) ORM problem, but ORM::empty_pk() should check $this->_object[$this->_primary_key] for existence.

Doing ORM::factory('model')->as_array() isn't failing for me with the latest checkout - can you verify this issue still exists?

This affects me as well. I did some debugging and it looks it has something to do with corrupted session data.

When it works, session data looks like this:

last_active|i:1264586990;pcsy_auth|O:10:"Model_User":6:{s:15:"*_object_name";s:4:"user";s:10:"*_object";a:6:{s:2:"id";i:1;s:5:"email";s:9:"[email protected]";s:8:"username";s:6:"zimage";s:8:"password";s:50:"ceaa...";s:6:"logins";i:67;s:10:"last_login";i:1264586964;}s:11:"*_changed";a:0:{}s:10:"*_loaded";b:1;s:9:"*_saved";b:1;s:11:"*_sorting";a:1:{s:2:"id";s:3:"ASC";}}

And when it says "Undefned index: id" the seeions data looks like this:

last_active|i:1264581783;pcsy_auth|O:10:"Model_User":6:{s:15:"*_object_name";s:4:"user";s:10:"*_object";a:0:{}s:11:"*_changed";a:0:{}s:10:"*_loaded";b:1;s:9:"*_saved";b:1;s:11:"*_sorting";a:1:{s:2:"id";s:3:"ASC";}}

_object is an empty array, so it doesn't have the 'id' key, which is looked for... I still don't know why the session looks like this, but anyway orm should handle this situation more gracefully, doesn't it?

What's the status on this bug? It is still present in KO 3.0.4 with the most recent versions of ORM and Auth taken from Github.

The bug-report seems to have had no activity the past 6 months: http://dev.kohanaframework.org/issues/2231

Is there anybody who at least has a work-around? The bug appears on /modules/orm/classes/kohana/orm.php, line 1316. I am thinking of changing the original code:


/**
* Returns the value of the primary key
*
* @return mixed primary key
*/
public function pk()
{
return $this->_object[$this->_primary_key];
}


To something like:


/**
* Returns the value of the primary key
*
* @return mixed primary key
*/
public function pk()
{
if(isset($this->_object[$this->_primary_key]))
{
return $this->_object[$this->_primary_key];
}
else
{
// Session is broken, have the user login again for a fresh session
Request::instance()->redirect('/login');
}
}


EDIT: Well, the above code doesn't even seem to work :( /EDIT

This way at least the user has the minor inconvenience of loggin in again, instead of seeing a crashed site...

But I hate to remember to insert this code again when I update Kohana or the ORM module. Any better solutions out there?

im experiencing this with kohana 3.0.7, is there a way to fix it or do i have to add try {} everywhere ?

Try this: http://forum.kohanaframework.org/comments.php?DiscussionID=6413&page=1#Item_11, it helped me, in a way.

Same as @peta.
Anyone?

I had the same problem working with the Auth module, figured out the session gets a corrupted ORM object (doesn't make the find() call) and this was caused to an error while trying to use the model (my own fault). To solve this, I just added

protected $_reload_on_wakeup = false;

to Model_Auth_User (or whichever model you are having the problem with) and destroyed the session (or cookie). Then debug your code. Once your code is in working order, you can either set the above line to true, or just delete it (true is default) and everything works again.

Any help on what Zeelot3k meant (what exactly to do with the model)? I have added the fix that czukowski referenced but now I just get logged off every time my page loads. I really need to find out where the fatal error is.